Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1166-carbondata@git.apache.org>
In-Reply-To: <git-pr-1166-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1166: [CARBONDATA-1305] Add limit for external dict...
Content-Type: text/plain
Message-Id: <20170714071132.B181DE0A38@git1-us-west.apache.org>
Date: Fri, 14 Jul 2017 07:11:32 +0000 (UTC)
archived-at: Fri, 14 Jul 2017 07:11:34 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1166#discussion_r127397726
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala ---
    @@ -460,6 +467,10 @@ class CarbonGlobalDictionaryGenerateRDD(
                           s"\n write sort info: $sortIndexWriteTime")
             }
           } catch {
    +        case dictionaryException: DictionaryLimitExceededException =>
    --- End diff --
    
    use a generic NoRetryExceptionClass instead of Specific exception  class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---