Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1146-carbondata@git.apache.org>
In-Reply-To: <git-pr-1146-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...
Content-Type: text/plain
Message-Id: <20170711053055.2EA9ADFF8A@git1-us-west.apache.org>
Date: Tue, 11 Jul 2017 05:30:55 +0000 (UTC)
archived-at: Tue, 11 Jul 2017 05:30:57 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1146#discussion_r126598933
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java ---
    @@ -421,4 +418,67 @@ public boolean isSortColumn() {
       public void setSortColumn(boolean sortColumn) {
         isSortColumn = sortColumn;
       }
    +
    +  @Override
    +  public void write(DataOutput out) throws IOException {
    +    out.writeInt(dataType.ordinal());
    +    WritableUtil.writeString(out, columnName);
    +    WritableUtil.writeString(out, columnUniqueId);
    +    WritableUtil.writeString(out, columnReferenceId);
    +    if (encodingList == null) {
    +      out.writeInt(0);
    +    } else {
    +      out.writeInt(encodingList.size());
    +      for (Encoding encoding : encodingList) {
    +        out.writeInt(encoding.ordinal());
    +      }
    +    }
    +    out.writeBoolean(isDimensionColumn);
    +    out.writeInt(scale);
    +    out.writeInt(precision);
    +    out.writeInt(schemaOrdinal);
    +    out.writeInt(numberOfChild);
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---