Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1146-carbondata@git.apache.org>
In-Reply-To: <git-pr-1146-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...
Content-Type: text/plain
Message-Id: <20170711040806.36BA3DFC26@git1-us-west.apache.org>
Date: Tue, 11 Jul 2017 04:08:05 +0000 (UTC)
archived-at: Tue, 11 Jul 2017 04:08:08 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1146#discussion_r126590721
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -101,51 +109,50 @@
       private static final String FILTER_PREDICATE =
           "mapreduce.input.carboninputformat.filter.predicate";
       private static final String COLUMN_PROJECTION = "mapreduce.input.carboninputformat.projection";
    -  private static final String CARBON_TABLE = "mapreduce.input.carboninputformat.table";
    +  private static final String TABLE_INFO = "mapreduce.input.carboninputformat.tableinfo";
       private static final String CARBON_READ_SUPPORT = "mapreduce.input.carboninputformat.readsupport";
     
    +  // a cache for carbon table, it will be used in task side
    +  private CarbonTable carbonTable;
    +
       /**
    -   * It is optional, if user does not set then it reads from store
    -   *
    -   * @param configuration
    -   * @param carbonTable
    -   * @throws IOException
    +   * Set the `tableInfo` in `configuration`
        */
    -  public static void setCarbonTable(Configuration configuration, CarbonTable carbonTable)
    +  public static void setTableInfo(Configuration configuration, TableInfo tableInfo)
           throws IOException {
    -    if (null != carbonTable) {
    -      configuration.set(CARBON_TABLE, ObjectSerializationUtil.convertObjectToString(carbonTable));
    +    if (null != tableInfo) {
    +      configuration.set(TABLE_INFO, ObjectSerializationUtil.convertObjectToString(tableInfo));
         }
       }
     
    -  public static CarbonTable getCarbonTable(Configuration configuration) throws IOException {
    -    String carbonTableStr = configuration.get(CARBON_TABLE);
    -    if (carbonTableStr == null) {
    -      populateCarbonTable(configuration);
    -      // read it from schema file in the store
    -      carbonTableStr = configuration.get(CARBON_TABLE);
    -      return (CarbonTable) ObjectSerializationUtil.convertStringToObject(carbonTableStr);
    -    }
    -    return (CarbonTable) ObjectSerializationUtil.convertStringToObject(carbonTableStr);
    +  /**
    +   * Get TableInfo object from `configuration`
    +   */
    +  private TableInfo getTableInfo(Configuration configuration) throws IOException {
    +    String tableInfoStr = configuration.get(TABLE_INFO);
    --- End diff --
    
    is null check required for `tableInfoStr` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---