Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1146-carbondata@git.apache.org>
In-Reply-To: <git-pr-1146-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1146: [CARBONDATA-1286] Change Query related RDD to...
Content-Type: text/plain
Message-Id: <20170711040059.41493DFC26@git1-us-west.apache.org>
Date: Tue, 11 Jul 2017 04:00:59 +0000 (UTC)
archived-at: Tue, 11 Jul 2017 04:01:01 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1146#discussion_r126590183
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -206,4 +202,68 @@ public void setStorePath(String storePath) {
         }
         return true;
       }
    +
    +  /**
    +   * This method will return the table size. Default table block size will be considered
    +   * in case not specified by the user
    +   */
    +  int getTableBlockSizeInMB() {
    +    String tableBlockSize = null;
    +    // In case of old store there will not be any map for table properties so table properties
    +    // will be null
    +    Map<String, String> tableProperties = getFactTable().getTableProperties();
    +    if (null != tableProperties) {
    +      tableBlockSize = tableProperties.get(CarbonCommonConstants.TABLE_BLOCKSIZE);
    +    }
    +    if (null == tableBlockSize) {
    +      tableBlockSize = CarbonCommonConstants.BLOCK_SIZE_DEFAULT_VAL;
    +      LOGGER.info("Table block size not specified for " + getTableUniqueName()
    +          + ". Therefore considering the default value "
    +          + CarbonCommonConstants.BLOCK_SIZE_DEFAULT_VAL + " MB");
    +    }
    +    return Integer.parseInt(tableBlockSize);
    +  }
    +
    +  @Override
    +  public void write(DataOutput out) throws IOException {
    +    WritableUtil.writeString(out, databaseName);
    +    WritableUtil.writeString(out, tableUniqueName);
    +    factTable.write(out);
    +    out.writeLong(lastUpdatedTime);
    +    WritableUtil.writeString(out, metaDataFilepath);
    +    WritableUtil.writeString(out, storePath);
    +  }
    +
    +  @Override
    +  public void readFields(DataInput in) throws IOException {
    +    this.databaseName = WritableUtil.readString(in);
    +    this.tableUniqueName = WritableUtil.readString(in);
    +    this.factTable = new TableSchema();
    +    this.factTable.readFields(in);
    +    this.lastUpdatedTime = in.readLong();
    +    this.metaDataFilepath = WritableUtil.readString(in);
    +    this.storePath = WritableUtil.readString(in);
    +  }
    +
    +  public AbsoluteTableIdentifier getOrCreateAbsoluteTableIdentifier() {
    +    if (identifier == null) {
    +      CarbonTableIdentifier carbontableIdentifier =
    +          new CarbonTableIdentifier(databaseName, factTable.getTableName(), factTable.getTableId());
    +      identifier = new AbsoluteTableIdentifier(storePath, carbontableIdentifier);
    +    }
    +    return identifier;
    +  }
    +
    +  public byte[] serielize() throws IOException {
    +    ByteArrayOutputStream bao = new ByteArrayOutputStream();
    +    this.write(new DataOutputStream(bao));
    +    return bao.toByteArray();
    +  }
    +
    +  public static TableInfo deserielize(byte[] bytes) throws IOException {
    --- End diff --
    
    Typo, change to `deserialize`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---