Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1102-carbondata@git.apache.org>
In-Reply-To: <git-pr-1102-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...
Content-Type: text/plain
Message-Id: <20170707024022.E6680E1863@git1-us-west.apache.org>
Date: Fri,  7 Jul 2017 02:40:22 +0000 (UTC)
archived-at: Fri, 07 Jul 2017 02:40:24 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1102#discussion_r126058814
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java ---
    @@ -15,9 +15,25 @@
      * limitations under the License.
      */
     
    -package org.apache.carbondata.core.datastore.page.compression;
    +package org.apache.carbondata.core.datastore.page.statistics;
     
    -public interface Compression {
    -  byte[] compress(byte[] input);
    -  byte[] decompress(byte[] input);
    +import java.util.BitSet;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +
    +public interface SimpleStatsResult {
    +
    +  byte[] getMinAsBytes();
    +
    +  byte[] getMaxAsBytes();
    +
    +  Object getMin();
    +
    +  Object getMax();
    +
    +  BitSet getNullBits();
    +
    +  int getDecimal();
    --- End diff --
    
    Better name as `getDecimalPoint`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---