Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EF54E200CCC for ; Fri, 7 Jul 2017 04:08:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EDDAB167ED8; Fri, 7 Jul 2017 02:08:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CDF6167ED7 for ; Fri, 7 Jul 2017 04:08:51 +0200 (CEST) Received: (qmail 12005 invoked by uid 500); 7 Jul 2017 02:08:50 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 11995 invoked by uid 99); 7 Jul 2017 02:08:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jul 2017 02:08:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8D19CE78B0; Fri, 7 Jul 2017 02:08:48 +0000 (UTC) From: chenliang613 To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi... Content-Type: text/plain Message-Id: <20170707020849.8D19CE78B0@git1-us-west.apache.org> Date: Fri, 7 Jul 2017 02:08:48 +0000 (UTC) archived-at: Fri, 07 Jul 2017 02:08:52 -0000 Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126056257 --- Diff: core/src/main/java/org/apache/carbondata/core/stats/QueryStatisticsRecorderImpl.java --- @@ -101,45 +101,47 @@ public String collectExecutorStatistics() { long scannedPages = 0; try { for (QueryStatistic statistic : queryStatistics) { - switch (statistic.getMessage()) { - case QueryStatisticsConstants.LOAD_BLOCKS_EXECUTOR: - load_blocks_time += statistic.getTimeTaken(); - break; - case QueryStatisticsConstants.SCAN_BLOCKlET_TIME: - scan_blocks_time += statistic.getCount(); - break; - case QueryStatisticsConstants.SCAN_BLOCKS_NUM: - scan_blocks_num += statistic.getCount(); - break; - case QueryStatisticsConstants.LOAD_DICTIONARY: - load_dictionary_time += statistic.getTimeTaken(); - break; - case QueryStatisticsConstants.RESULT_SIZE: - result_size += statistic.getCount(); - break; - case QueryStatisticsConstants.EXECUTOR_PART: - total_executor_time += statistic.getTimeTaken(); - break; - case QueryStatisticsConstants.TOTAL_BLOCKLET_NUM: - total_blocklet = statistic.getCount(); - break; - case QueryStatisticsConstants.VALID_SCAN_BLOCKLET_NUM: - valid_scan_blocklet = statistic.getCount(); - break; - case QueryStatisticsConstants.VALID_PAGE_SCANNED: - valid_pages_blocklet = statistic.getCount(); - break; - case QueryStatisticsConstants.TOTAL_PAGE_SCANNED: - total_pages = statistic.getCount(); - break; - case QueryStatisticsConstants.READ_BLOCKlET_TIME: - readTime = statistic.getCount(); - break; - case QueryStatisticsConstants.PAGE_SCANNED: - scannedPages = statistic.getCount(); - break; - default: - break; + if (statistic.getMessage() != null) { --- End diff -- question : only add one row code "if (statistic.getMessage() != null)", why need to change other code format ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---