Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1144-carbondata@git.apache.org>
In-Reply-To: <git-pr-1144-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1144: [WIP] String datatype will be no dictionary c...
Content-Type: text/plain
Message-Id: <20170707010055.88B87DFF9F@git1-us-west.apache.org>
Date: Fri,  7 Jul 2017 01:00:54 +0000 (UTC)
archived-at: Fri, 07 Jul 2017 01:00:58 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1144#discussion_r126050555
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
    @@ -572,6 +572,7 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
     
         // All excluded cols should be there in create table cols
         if (tableProperties.get(CarbonCommonConstants.DICTIONARY_EXCLUDE).isDefined) {
    +      LOGGER.warn("dictionary_exclude option was deprecated")
    --- End diff --
    
    add one more message: "by default string column does not use global dictionary"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---