Return-Path: <issues-return-13971-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id E42C5200CBD
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  6 Jul 2017 19:13:23 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id E2ED7166F2F; Thu,  6 Jul 2017 17:13:23 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2C8F3166F2A
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  6 Jul 2017 19:13:23 +0200 (CEST)
Received: (qmail 20910 invoked by uid 500); 6 Jul 2017 17:13:22 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 20901 invoked by uid 99); 6 Jul 2017 17:13:22 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 17:13:22 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 49CC5E10F3; Thu,  6 Jul 2017 17:13:22 +0000 (UTC)
From: QiangCai <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1125-carbondata@git.apache.org>
In-Reply-To: <git-pr-1125-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...
Content-Type: text/plain
Message-Id: <20170706171322.49CC5E10F3@git1-us-west.apache.org>
Date: Thu,  6 Jul 2017 17:13:22 +0000 (UTC)
archived-at: Thu, 06 Jul 2017 17:13:24 -0000

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r125954219
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java ---
    @@ -43,13 +44,30 @@
       private List<List<String>> listInfo;
     
       /**
    -   * number of partitions
    +   * number of hash partitions
        */
    -  private int numPartitions;
    +  private int hashNumber;
    +
    +  /**
    +   * total count of partitions
    +   */
    +  private int numberOfPartitions;
    --- End diff --
    
    for hash partition,  hashNumber is same with numberOfPartitions.
    why we need two variables?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---