Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenliang613 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1062-carbondata@git.apache.org>
In-Reply-To: <git-pr-1062-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause I...
Content-Type: text/plain
Message-Id: <20170702153416.98C9EDF9AB@git1-us-west.apache.org>
Date: Sun,  2 Jul 2017 15:34:15 +0000 (UTC)
archived-at: Sun, 02 Jul 2017 15:35:51 -0000

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1062#discussion_r125186117
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java ---
    @@ -181,29 +182,25 @@ private void fillFilter2QueryModel(QueryModel queryModel,
                   case EXACTLY:
                     LessThanEqualToExpression less = new LessThanEqualToExpression(colExpression,
                         new LiteralExpression(value, coltype));
    -                rangeFilter.add(less);
    +                rangeConjuncts.add(less);
                     break;
                   case BELOW:
                     LessThanExpression less2 =
                         new LessThanExpression(colExpression, new LiteralExpression(value, coltype));
    -                rangeFilter.add(less2);
    +                rangeConjuncts.add(less2);
                     break;
                   default:
                     throw new AssertionError("Unhandled bound: " + range.getHigh().getBound());
                 }
               }
    +          disjuncts.addAll(rangeConjuncts);
             }
           }
    -
           if (singleValues.size() == 1) {
             Expression ex = null;
             if (coltype.equals(DataType.STRING)) {
               ex = new EqualToExpression(colExpression,
                   new LiteralExpression(((Slice) singleValues.get(0)).toStringUtf8(), coltype));
    -        } else if (coltype.equals(DataType.TIMESTAMP) || coltype.equals(DataType.DATE)) {
    --- End diff --
    
    Can you explain, why remove these code  for fixing this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---