Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1079-carbondata@git.apache.org>
In-Reply-To: <git-pr-1079-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1079: [WIP]Measure Filter implementation
Content-Type: text/plain
Message-Id: <20170701021144.F0C5DE152F@git1-us-west.apache.org>
Date: Sat,  1 Jul 2017 02:11:44 +0000 (UTC)
archived-at: Sat, 01 Jul 2017 02:11:48 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1079#discussion_r125152345
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java ---
    @@ -102,9 +109,15 @@ public void update(Object value) {
             break;
           case DECIMAL:
             BigDecimal decimalValue = DataTypeUtil.byteToBigDecimal((byte[]) value);
    -        decimal = decimalValue.scale();
    -        BigDecimal val = (BigDecimal) min;
    -        nonExistValue = (val.subtract(new BigDecimal(1.0)));
    +        if (isFirst) {
    --- End diff --
    
    I think this `isFirst` is required. just check null for max or min here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---