carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1215: [CARBONDATA-1328] Clean code for memory manag...
Date Sun, 30 Jul 2017 15:54:21 GMT
GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1215

    [CARBONDATA-1328] Clean code for memory manager and unsafe sort

    Deprecated old property: sort.inmemory.size.inmb, enable.offheap.sort
    Added new property: carbon.sort.storage.inmemory.size.inmb, carbon.unsafe.working.memory.in.mb,
enable.offheap
    Removed copying of block from working memory to sort storage memory
    Now all the unsafe flow must use CarbonUnsfeMemoryManager for allocating/ removing unsafe
memory
    If user has configured old property then internally it will be converted to new property
    for ex: If user has configured sort.inmemory.size.inmb then 20% memory will be used as
working memory and rest for storage memory
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata master25-07-2017

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1215
    
----
commit 2e9b1f4ff254dc959abc7e28aca026badfea8d23
Author: kumarvishal <kumarvishal.1802@gmail.com>
Date:   2017-07-30T15:50:01Z

    Clean code for memory manager and unsafe sort
    Deprecated old property: sort.inmemory.size.inmb, enable.offheap.sort
    Added new property: carbon.sort.storage.inmemory.size.inmb, carbon.unsafe.working.memory.in.mb,
enable.offheap
    Removed copying of block from working memory to sort storage memory
    Now all the unsafe flow must use CarbonUnsfeMemoryManager for allocating/ removing unsafe
memory
    If user has configured old property then internally it will be converted to new property
    for ex: If user has configured sort.inmemory.size.inmb then 20% memory will be used as
working memory and rest for storage memory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message