carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1212: [CARBONDATA-1340]support tables with only mea...
Date Sat, 29 Jul 2017 13:23:20 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1212#discussion_r130220711
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
    @@ -253,13 +253,13 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser
{
         }
         val (dims, msrs, noDictionaryDims, sortKeyDims) = extractDimAndMsrFields(
           fields, tableProperties)
    -    if (dims.isEmpty && !isAlterFlow) {
    -      throw new MalformedCarbonCommandException(
    -        s"Table ${dbName.getOrElse(CarbonCommonConstants.DATABASE_DEFAULT_NAME)}.$tableName
" +
    -        "can not be created without key columns. Please use DICTIONARY_INCLUDE or " +
    -        "DICTIONARY_EXCLUDE to set at least one key column " +
    -        "if all specified columns are numeric types")
    -    }
    +//    if (dims.isEmpty && !isAlterFlow) {
    --- End diff --
    
    delete it if not required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message