carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1136: [CARBONDATA-1268] Support encoding strategy f...
Date Sun, 23 Jul 2017 02:45:37 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1136#discussion_r128908871
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DictDimensionIndexCodec.java
---
    @@ -0,0 +1,70 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page.encoding;
    +
    +import org.apache.carbondata.core.datastore.DimensionType;
    +import org.apache.carbondata.core.datastore.columnar.BlockIndexerStorageForInt;
    +import org.apache.carbondata.core.datastore.columnar.BlockIndexerStorageForNoInvertedIndexForInt;
    +import org.apache.carbondata.core.datastore.columnar.BlockIndexerStorageForNoInvertedIndexForShort;
    +import org.apache.carbondata.core.datastore.columnar.BlockIndexerStorageForShort;
    +import org.apache.carbondata.core.datastore.columnar.IndexStorage;
    +import org.apache.carbondata.core.datastore.compression.Compressor;
    +import org.apache.carbondata.core.datastore.page.ColumnPage;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.metadata.ColumnarFormatVersion;
    +import org.apache.carbondata.core.util.ByteUtil;
    +
    +public class DictDimensionIndexCodec extends IndexStorageCodec {
    +
    +  DictDimensionIndexCodec(boolean isSort, boolean isInvertedIndex, Compressor compressor)
{
    +    super(isSort, isInvertedIndex, compressor);
    +  }
    +
    +  @Override
    +  public String getName() {
    +    return "DictDimensionIndexCodec";
    +  }
    +
    +  @Override
    +  public EncodedColumnPage encode(ColumnPage input) {
    +    IndexStorage indexStorage;
    +    byte[][] data = input.getByteArrayPage();
    +    if (isInvertedIndex) {
    +      if (version == ColumnarFormatVersion.V3) {
    +        indexStorage = new BlockIndexerStorageForShort(data, true, false, isSort);
    +      } else {
    +        indexStorage = new BlockIndexerStorageForInt(data, true, false, isSort);
    +      }
    +    } else {
    +      if (version == ColumnarFormatVersion.V3) {
    +        indexStorage = new BlockIndexerStorageForNoInvertedIndexForShort(data, false);
    +      } else {
    +        indexStorage = new BlockIndexerStorageForNoInvertedIndexForInt(data);
    +      }
    +    }
    +    byte[] flattened = ByteUtil.flatten(indexStorage.getDataPage());
    +    byte[] compressed = compressor.compressByte(flattened);
    +    return new EncodedDimensionPage(input.getPageSize(), compressed, indexStorage,
    +        DimensionType.GLOBAL_DICTIONARY);
    +  }
    +
    +  @Override
    +  public ColumnPage decode(byte[] input, int offset, int length) throws MemoryException
{
    --- End diff --
    
    I think you are going to implement in future. May be at this point move this to `IndexStorageCodec`
and throw UnsupportedException. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message