carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lionelcao <...@git.apache.org>
Subject [GitHub] carbondata pull request #1183: [CARBONDATA-1312] fix list partition compare ...
Date Fri, 21 Jul 2017 08:19:08 GMT
Github user lionelcao commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1183#discussion_r128707984
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
    @@ -63,6 +64,9 @@ public static BitSet getPartitionMapForRangeFilter(PartitionInfo partitionInfo,
               for (String value : values.get(i)) {
                 Object listValue = PartitionUtil.getDataBasedOnDataType(value, partitionColumnDataType,
                     timestampFormatter, dateFormatter);
    +            if (listValue instanceof String) {
    +              listValue = ByteUtil.toBytes((String)listValue);
    +            }
    --- End diff --
    
    cannot move to outside here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message