carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1189: [CARBONDATA-1322] Insert overwrite support an...
Date Thu, 20 Jul 2017 10:40:36 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1189#discussion_r128481387
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -1264,6 +1264,14 @@
     
       public static final String ENABLE_HIVE_SCHEMA_META_STORE_DEFAULT = "false";
     
    +  /**
    +   * There is more often that in production uses different drivers for load and queries.
So in case
    +   * of load driver user should set this property to enable loader specific clean up.
    +   */
    +  public static final String TABLE_LOADER_DRIVER = "spark.carbon.table.loader.driver";
    --- End diff --
    
    I think this property not just for loading, any transactional operation should use this
driver. So can you rename it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message