carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenerlu <...@git.apache.org>
Subject [GitHub] carbondata pull request #1173: [CARBONDATA-1209] add partitionId in show par...
Date Wed, 19 Jul 2017 16:46:57 GMT
Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1173#discussion_r128302516
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala
---
    @@ -146,31 +146,31 @@ class TestShowPartition  extends QueryTest with BeforeAndAfterAll
{
     
       test("show partition table: hash table") {
         // EqualTo
    -    checkAnswer(sql("show partitions hashTable"), Seq(Row("empno=HASH_NUMBER(3)")))
    +    checkAnswer(sql("show partitions hashTable"), Seq(Row("empno = HASH_NUMBER(3)")))
     
       }
     
       test("show partition table: range partition") {
         // EqualTo
    -    checkAnswer(sql("show partitions rangeTable"), Seq(Row("doj=default"),
    -      Row("doj<01-01-2010"), Row("01-01-2010<=doj<01-01-2015")))
    +    checkAnswer(sql("show partitions rangeTable"), Seq(Row("0, doj = DEFAULT"),
    +      Row("1, doj < 01-01-2010"), Row("2, 01-01-2010 <= doj < 01-01-2015")))
       }
     
       test("show partition table: list partition") {
         // EqualTo
    -    checkAnswer(sql("show partitions listTable"), Seq(Row("workgroupcategory=default"),
    -      Row("workgroupcategory=0"), Row("workgroupcategory=1"), Row("workgroupcategory=2,
3")))
    +    checkAnswer(sql("show partitions listTable"), Seq(Row("0, workgroupcategory = DEFAULT"),
    --- End diff --
    
    May be keep default will be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message