carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1183: [CARBONDATA-1312] fix list partition compare ...
Date Wed, 19 Jul 2017 06:56:32 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1183#discussion_r128164470
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
    @@ -63,6 +64,9 @@ public static BitSet getPartitionMapForRangeFilter(PartitionInfo partitionInfo,
               for (String value : values.get(i)) {
                 Object listValue = PartitionUtil.getDataBasedOnDataType(value, partitionColumnDataType,
                     timestampFormatter, dateFormatter);
    +            if (listValue instanceof String) {
    +              listValue = ByteUtil.toBytes((String)listValue);
    +            }
    --- End diff --
    
    please improve performance and refractory code.
    we should convert value only once. please move the code to the outside of for loop.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message