carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...
Date Mon, 17 Jul 2017 02:03:14 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1102#discussion_r127624668
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java
---
    @@ -32,23 +39,37 @@
       /**
        * maxValue
        */
    -  private Object maxValue;
    +  protected Object maxValue;
    --- End diff --
    
    I feel it is not safe to change even method name or access specifier, just extend this
class or wrap it into another class to add more variables or do any changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message