carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1166: [CARBONDATA-1305] Add limit for external dict...
Date Thu, 13 Jul 2017 05:31:13 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1166#discussion_r127131222
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
    @@ -83,7 +84,12 @@ case class PrimitiveParser(dimension: CarbonDimension,
     
       def parseString(input: String): Unit = {
         if (hasDictEncoding && input != null) {
    -      set.add(input)
    +      if (set.size < CarbonCommonConstants.MAX_EXTERNAL_DICTIONARY_SIZE) {
    --- End diff --
    
    This check will be done for each value for each column...please ensure there is no performance
degradation in dictionary generation due to this check...try with some 100 columns with and
without this change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message