carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...
Date Wed, 12 Jul 2017 07:14:42 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126876373
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -266,26 +264,22 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration
           // process and resolve the expression
           Expression filter = getFilterPredicates(job.getConfiguration());
           CarbonTable carbonTable = getCarbonTable(job.getConfiguration());
    +      PartitionInfo partitionInfo = carbonTable.getPartitionInfo(carbonTable.getFactTableName());
    --- End diff --
    
    please move code  to 274 line.
    Variable carbonTable should be checked before it was used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message