carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1099: [CARBONDATA-1232] Datamap implementation for ...
Date Mon, 10 Jul 2017 13:26:58 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1099#discussion_r126420383
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java
---
    @@ -69,32 +72,54 @@ public TableDataMap getDataMap(AbsoluteTableIdentifier identifier,
String dataMa
        * @param mapType
        * @return
        */
    -  public TableDataMap createTableDataMap(AbsoluteTableIdentifier identifier, DataMapType
mapType,
    -      String dataMapName) {
    -    Map<String, TableDataMap> map = dataMapMappping.get(mapType);
    -    if (map == null) {
    -      map = new HashMap<>();
    -      dataMapMappping.put(mapType, map);
    +  public TableDataMap createTableDataMap(AbsoluteTableIdentifier identifier,
    --- End diff --
    
    this method should be private


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message