carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1153: [CARBONDATA-1229]acquired meta.lock during ta...
Date Mon, 10 Jul 2017 11:39:57 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1153#discussion_r126397196
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -860,17 +852,19 @@ case class CarbonDropTableCommand(ifExistsSet: Boolean,
             .dropTable(storePath, identifier)(sparkSession)
           LOGGER.audit(s"Deleted table [$tableName] under database [$dbName]")
         } finally {
    -      if (carbonLock != null && isLocked) {
    -        if (carbonLock.unlock()) {
    +      LOGGER.audit(s"Dropping table $dbName.$tableName failed as the Table is locked")
    --- End diff --
    
    This can be possible in positive case as well, both cases needs to be separately logged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message