carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1138: [CARBONDATA-1263]Single pass load does not ta...
Date Fri, 07 Jul 2017 04:33:17 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1138#discussion_r126067856
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -426,8 +426,14 @@ case class LoadTable(
               false
             }
           case illegal =>
    -        LOGGER.error(s"Can't use single_pass, because illegal syntax found: [" + illegal
+ "] " +
    -                     "Please set it as 'true' or 'false'")
    +        if (StringUtils.isNotEmpty(optionsFinal.get("all_dictionary_path").get) ||
    +            StringUtils.isNotEmpty(optionsFinal.get("columndict").get)) {
    +          throw new MalformedCarbonCommandException(
    +            "Can not use all_dictionary_path or columndict with Illegal Value:[" + illegal
+ "] " +
    +            "of single_pass. Please set it to True")
    +        }
    +        LOGGER.info("Can't use single_pass, because illegal syntax found: [" + illegal
+ "] " +
    --- End diff --
    
    this will never be logged as exception is thrown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message