carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1099: [CARBONDATA-1232] Datamap implementation for ...
Date Fri, 07 Jul 2017 03:39:56 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1099#discussion_r126063998
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/AbstractTableDataMap.java
---
    @@ -26,28 +27,29 @@
      * DataMap at the table level, user can add any number of datamaps for one table. Depends
      * on the filter condition it can prune the blocklets.
      */
    -public interface TableDataMap extends EventListener {
    +public abstract class AbstractTableDataMap implements EventListener {
    --- End diff --
    
    Since it is abstract class better name as `AbstractTableDataMap` and one Segment can have
multiple datamaps so `SegmentDataMap` may not justify the name


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message