carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lionelcao <...@git.apache.org>
Subject [GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...
Date Fri, 07 Jul 2017 03:15:36 GMT
Github user lionelcao commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r126062042
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
    @@ -43,13 +44,30 @@
       private List<List<String>> listInfo;
     
       /**
    -   * number of partitions
    +   * number of hash partitions
        */
    -  private int numPartitions;
    +  private int hashNumber;
    +
    +  /**
    +   * total count of partitions
    +   */
    +  private int numberOfPartitions;
    --- End diff --
    
    I think it represent different concept. Though they are equal in hash table. That would
be more clear for developers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message