carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1102: [CARBONDATA-1098] Change page statistics use ...
Date Fri, 07 Jul 2017 02:38:41 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1102#discussion_r126058673
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
    @@ -15,9 +15,25 @@
      * limitations under the License.
      */
     
    -package org.apache.carbondata.core.datastore.page.compression;
    +package org.apache.carbondata.core.datastore.page.statistics;
     
    -public interface Compression {
    -  byte[] compress(byte[] input);
    -  byte[] decompress(byte[] input);
    +import java.util.BitSet;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +
    +public interface SimpleStatsResult {
    +
    +  byte[] getMinAsBytes();
    +
    +  byte[] getMaxAsBytes();
    +
    +  Object getMin();
    +
    +  Object getMax();
    +
    +  BitSet getNullBits();
    --- End diff --
    
    Ideally the null bits are supposed part of page, it should not be part of stats


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message