carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...
Date Fri, 07 Jul 2017 02:08:48 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1142#discussion_r126056257
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/stats/QueryStatisticsRecorderImpl.java
---
    @@ -101,45 +101,47 @@ public String collectExecutorStatistics() {
         long scannedPages = 0;
         try {
           for (QueryStatistic statistic : queryStatistics) {
    -        switch (statistic.getMessage()) {
    -          case QueryStatisticsConstants.LOAD_BLOCKS_EXECUTOR:
    -            load_blocks_time += statistic.getTimeTaken();
    -            break;
    -          case QueryStatisticsConstants.SCAN_BLOCKlET_TIME:
    -            scan_blocks_time += statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.SCAN_BLOCKS_NUM:
    -            scan_blocks_num += statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.LOAD_DICTIONARY:
    -            load_dictionary_time += statistic.getTimeTaken();
    -            break;
    -          case QueryStatisticsConstants.RESULT_SIZE:
    -            result_size += statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.EXECUTOR_PART:
    -            total_executor_time += statistic.getTimeTaken();
    -            break;
    -          case QueryStatisticsConstants.TOTAL_BLOCKLET_NUM:
    -            total_blocklet = statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.VALID_SCAN_BLOCKLET_NUM:
    -            valid_scan_blocklet = statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.VALID_PAGE_SCANNED:
    -            valid_pages_blocklet = statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.TOTAL_PAGE_SCANNED:
    -            total_pages = statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.READ_BLOCKlET_TIME:
    -            readTime = statistic.getCount();
    -            break;
    -          case QueryStatisticsConstants.PAGE_SCANNED:
    -            scannedPages = statistic.getCount();
    -            break;
    -          default:
    -            break;
    +        if (statistic.getMessage() != null) {
    --- End diff --
    
    question : only add one row code "if (statistic.getMessage() != null)", why need to change
other code format ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message