carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...
Date Thu, 06 Jul 2017 17:13:23 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1125#discussion_r125957701
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -274,28 +275,27 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration
           CarbonInputFormatUtil.processFilterExpression(filter, carbonTable);
     
           // prune partitions for filter query on partition table
    -      BitSet matchedPartitions = null;
    -      if (null != filter) {
    -        PartitionInfo partitionInfo = carbonTable.getPartitionInfo(carbonTable.getFactTableName());
    -        if (null != partitionInfo) {
    -          Partitioner partitioner = PartitionUtil.getPartitioner(partitionInfo);
    -          matchedPartitions = new FilterExpressionProcessor()
    -              .getFilteredPartitions(filter, partitionInfo, partitioner);
    +      BitSet matchedPartitions = setMatchedPartitions(null, carbonTable, filter);
    +      if (partitionInfo != null) {
    +        Partitioner partitioner = PartitionUtil.getPartitioner(partitionInfo);
    --- End diff --
    
    this method was invoked twice


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message