carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cenyuhai <...@git.apache.org>
Subject [GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...
Date Thu, 06 Jul 2017 05:56:57 GMT
Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/984#discussion_r125816477
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
    @@ -269,9 +270,9 @@ public ICarbonLock getTableUpdateStatusLock() {
        * @throws Exception
        */
       public String[] getDeleteDeltaFilePath(String blockFilePath) throws Exception {
    -    int tableFactPathLength = CarbonStorePath
    -        .getCarbonTablePath(absoluteTableIdentifier.getStorePath(),
    -            absoluteTableIdentifier.getCarbonTableIdentifier()).getFactDir().length()
+ 1;
    +    String factTableDir =
    +        absoluteTableIdentifier.getCarbonTableIdentifier().getTableName() + File.separator
+ "Fact";
    +    int tableFactPathLength = blockFilePath.indexOf(factTableDir) + factTableDir.length()
+ 1;
    --- End diff --
    
    Because when I create table, the location in table properties is 'hdfs:////user/xxxxx/fact',
but the fact dir is 'hdfs://cluster/user/xxxxx/fact', so getFactDir().length() + 1 is wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message