carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1133: [CARBONDATA-1261] Load data sql add 'header' ...
Date Wed, 05 Jul 2017 15:47:16 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1133#discussion_r125682912
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -441,6 +441,38 @@ case class LoadTable(
           val batchSortSizeInMB = options.getOrElse("batch_sort_size_inmb", null)
           val globalSortPartitions = options.getOrElse("global_sort_partitions", null)
           ValidateUtil.validateGlobalSortPartitions(globalSortPartitions)
    +
    +      // if there isn't file header in csv file and load sql doesn't provide FILEHEADER
option,
    +      // we should use table schema to generate file header.
    +      val headerOption = options.get("header")
    +      headerOption.isDefined match {
    --- End diff --
    
    I feel it is better to use if check, since false case is empty


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message