carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <>
Subject [GitHub] carbondata pull request #1099: [CARBONDATA-1232] Datamap implementation for ...
Date Wed, 05 Jul 2017 01:37:50 GMT
Github user jackylk commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/
    @@ -84,11 +121,11 @@
        * @param filterExp
        * @return
    -  boolean isFiltersSupported(FilterResolverIntf filterExp);
    +  public abstract boolean isFiltersSupported(FilterResolverIntf filterExp);
    --- End diff --
    I feel it is better to accept a `FilterType` as input and return boolean, so client is
not dependent on carbon's filter interface

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message