carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1119: [CarbonData-1250] change default partition id...
Date Mon, 03 Jul 2017 10:40:58 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1119#discussion_r125250632
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
    @@ -229,35 +229,37 @@ public static BitSet getPartitionMapForRangeFilter(PartitionInfo
partitionInfo,
           // filter value is in default partition
           if (isGreaterThan) {
             // GreaterThan(>), GreaterThanEqualTo(>=)
    -        partitionMap.set(numPartitions);
    +        partitionMap.set(0);
           } else {
             // LessThan(<), LessThanEqualTo(<=)
    -        partitionMap.set(0, partitioner.numPartitions());
    +        partitionMap.set(1, partitioner.numPartitions());
    --- End diff --
    
    no need to change it.
    It means all partitions were matched.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message