carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sounakr <>
Subject [GitHub] carbondata pull request #1079: [WIP]Measure Filter implementation
Date Sun, 02 Jul 2017 20:15:34 GMT
Github user sounakr commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/
    @@ -76,24 +99,25 @@ public static Comparator getComparatorByDataType(DataType dataType)
       static class DoubleComparator implements Comparator<Object> {
         @Override public int compare(Object key1, Object key2) {
    -      double result = (double) key1 - (double) key2;
    -      if (result < 0) {
    +      double key1Double1 = (double)key1;
    --- End diff --
    There is a scenario is a variable is a negative one the Key1 - Key2 wont give proper output.
Better to check greater or less than operator. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message