carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sounakr <...@git.apache.org>
Subject [GitHub] carbondata pull request #1079: [WIP]Measure Filter implementation
Date Sun, 02 Jul 2017 19:45:30 GMT
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1079#discussion_r125190853
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
    @@ -180,9 +185,27 @@ private static FilterExecuter createFilterExecuterTree(
        * @return
        */
       private static FilterExecuter getIncludeFilterExecuter(
    -      DimColumnResolvedFilterInfo dimColResolvedFilterInfo, SegmentProperties segmentProperties)
{
    -
    -    if (dimColResolvedFilterInfo.getDimension().isColumnar()) {
    +      DimColumnResolvedFilterInfo dimColResolvedFilterInfo,
    +      MeasureColumnResolvedFilterInfo msrColResolvedFilterInfo,
    +      SegmentProperties segmentProperties) {
    +    if (null != msrColResolvedFilterInfo && msrColResolvedFilterInfo.getMeasure().isColumnar())
{
    --- End diff --
    
    Done. Removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message