Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1104-carbondata@git.apache.org>
In-Reply-To: <git-pr-1104-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...
Content-Type: text/plain
Message-Id: <20170629102757.28EDCE10F3@git1-us-west.apache.org>
Date: Thu, 29 Jun 2017 10:27:57 +0000 (UTC)
archived-at: Thu, 29 Jun 2017 10:27:58 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1104#discussion_r124764409
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
    @@ -96,34 +96,37 @@ private boolean validateKeyValue(String key, String value) throws InvalidConfigu
               isValid = true;
             } catch (IllegalArgumentException iae) {
               throw new InvalidConfigurationException(
    -              "The key " + key + " can have only either FORCE or IGNORE or REDIRECT.");
    +              "The key " + key + " can have only either FORCE or IGNORE or REDIRECT or FAIL.");
             }
             break;
           case CARBON_OPTIONS_SORT_SCOPE:
             isValid = CarbonUtil.isValidSortOption(value);
             if (!isValid) {
               throw new InvalidConfigurationException("The sort scope " + key
    -              + " can have only either BATCH_SORT or LOCAL_SORT or NO_SORT.");
    +              + " can have only either BATCH_SORT or LOCAL_SORT or NO_SORT or GLOBAL_SORT.");
             }
             break;
           case CARBON_OPTIONS_BATCH_SORT_SIZE_INMB:
    -      case CARBON_OPTIONS_GLOBAL_SORT_PARTITIONS:
             isValid = CarbonUtil.validateValidIntType(value);
             if (!isValid) {
               throw new InvalidConfigurationException(
                   "The configured value for key " + key + " must be valid integer.");
             }
             break;
    +      case CARBON_OPTIONS_GLOBAL_SORT_PARTITIONS:
    --- End diff --
    
    Handle calling same method from load validation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---