Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenerlu <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1112-carbondata@git.apache.org>
In-Reply-To: <git-pr-1112-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...
Content-Type: text/plain
Message-Id: <20170629040237.B8185DFC24@git1-us-west.apache.org>
Date: Thu, 29 Jun 2017 04:02:37 +0000 (UTC)
archived-at: Thu, 29 Jun 2017 04:02:39 -0000

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1112#discussion_r124707828
  
    --- Diff: integration/presto/README.md ---
    @@ -59,28 +55,50 @@ Please follow the below steps to query carbondata in presto
       ```
     * config carbondata-connector for presto
       
    -  First:compile carbondata-presto integration module
    +  Firstly: Compile carbondata, including carbondata-presto integration module
       ```
       $ git clone https://github.com/apache/carbondata
    -  $ cd carbondata/integration/presto
    -  $ mvn clean package
    +  $ cd carbondata
    +  $ mvn -DskipTests -P{spark-version} -Dspark.version={spark-version-number} -Dhadoop.version={hadoop-version-number} clean package
    +  ```
    +  Replace the spark and hadoop version with you the version you used in your cluster.
    --- End diff --
    
    Maybe it will be better to delete these two "you".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---