Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: manishgupta88 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1097-carbondata@git.apache.org>
In-Reply-To: <git-pr-1097-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Content-Type: text/plain
Message-Id: <20170627085940.0142DDFB0D@git1-us-west.apache.org>
Date: Tue, 27 Jun 2017 08:59:40 +0000 (UTC)
archived-at: Tue, 27 Jun 2017 08:59:43 -0000

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124217603
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/DictionaryFieldConverterImpl.java ---
    @@ -80,11 +86,12 @@ public DictionaryFieldConverterImpl(DataField dataField,
           dictionaryMessage.setColumnName(dataField.getColumn().getColName());
           dictionaryMessage.setTableUniqueName(carbonTableIdentifier.getTableUniqueName());
           // for table initialization
    -      dictionaryMessage.setType(DictionaryMessageType.TABLE_INTIALIZATION);
    +//      dictionaryMessage.setType(DictionaryMessageType.COLUMN_INITIALIZATION);
    +      dictionaryMessage.setTableUniqueId(carbonTableIdentifier.getTableId());
           dictionaryMessage.setData("0");
    -      if (tableInitialize) {
    -        client.getDictionary(dictionaryMessage);
    -      }
    +//      if (tableInitialize) {
    +//        client.getDictionary(dictionaryMessage);
    +//      }
    --- End diff --
    
    Remove commented lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---