Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: manishgupta88 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1097-carbondata@git.apache.org>
In-Reply-To: <git-pr-1097-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Content-Type: text/plain
Message-Id: <20170627064237.787C8DFE1F@git1-us-west.apache.org>
Date: Tue, 27 Jun 2017 06:42:37 +0000 (UTC)
archived-at: Tue, 27 Jun 2017 06:42:39 -0000

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124189008
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java ---
    @@ -64,24 +66,34 @@ public void initializeGeneratorForTable(DictionaryMessage key) {
         }
       }
     
    +  public void initializeGeneratorForColumn(DictionaryMessage key) {
    +    tableMap.get(key.getTableUniqueId()).updateGenerator(key);
    +  }
    +
       public Integer size(DictionaryMessage key) {
    -    TableDictionaryGenerator generator = tableMap.get(key.getTableUniqueName());
    +    TableDictionaryGenerator generator = tableMap.get(key.getTableUniqueId());
         assert generator != null : "Table intialization for generator is not done";
         return generator.size(key);
       }
     
       public void writeDictionaryData() throws Exception {
         for (String tableUniqueName: tableMap.keySet()) {
           TableDictionaryGenerator generator = tableMap.get(tableUniqueName);
    -      generator.writeDictionaryData(tableUniqueName);
    +      generator.writeDictionaryData();
         }
       }
     
    -  public void writeTableDictionaryData(String tableUniqueName) throws Exception {
    -    TableDictionaryGenerator generator = tableMap.get(tableUniqueName);
    -    if (generator != null) {
    -      generator.writeDictionaryData(tableUniqueName);
    -    }
    +  public void writeTableDictionaryData(String tableUniqueId, CarbonTable carbonTable) throws Exception {
    +      TableDictionaryGenerator generator = tableMap.get(tableUniqueId);
    +    boolean tableExists = FileFactory.isFileExist(carbonTable.getMetaDataFilepath() + CarbonCommonConstants.FILE_SEPARATOR + tableUniqueId,
    --- End diff --
    
    correct the indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---