Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: manishgupta88 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1097-carbondata@git.apache.org>
In-Reply-To: <git-pr-1097-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Content-Type: text/plain
Message-Id: <20170627063806.43CF2DFE1F@git1-us-west.apache.org>
Date: Tue, 27 Jun 2017 06:38:06 +0000 (UTC)
archived-at: Tue, 27 Jun 2017 06:38:08 -0000

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124188452
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java ---
    @@ -40,21 +42,21 @@
       @Override
       public Integer generateKey(DictionaryMessage value)
           throws DictionaryGenerationException {
    -    TableDictionaryGenerator generator = tableMap.get(value.getTableUniqueName());
    -    assert generator != null : "Table initialization for generator is not done";
    +    TableDictionaryGenerator generator = tableMap.get(value.getTableUniqueId());
    +    if (generator == null) {
    +      throw new DictionaryGenerationException("Table Not Found");
    --- End diff --
    
    Change message in the assert statement....do not throw explicit exception


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---