Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: chenliang613 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1075-carbondata@git.apache.org>
In-Reply-To: <git-pr-1075-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1075: [WIP] Datamap implementation for Blocklet. 
Content-Type: text/plain
Message-Id: <20170624100121.F2A32DFB92@git1-us-west.apache.org>
Date: Sat, 24 Jun 2017 10:01:21 +0000 (UTC)
archived-at: Sat, 24 Jun 2017 10:01:24 -0000

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1075#discussion_r123874656
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/AbstractTableDataMap.java ---
    @@ -26,28 +27,28 @@
      * DataMap at the table level, user can add any number of datamaps for one table. Depends
      * on the filter condition it can prune the blocklets.
      */
    -public interface TableDataMap extends EventListener {
    +public abstract class AbstractTableDataMap implements EventListener {
     
       /**
        * It is called to initialize and load the required table datamap metadata.
        */
    -  void init(AbsoluteTableIdentifier identifier, String dataMapName);
    +  public abstract void init(AbsoluteTableIdentifier identifier, String dataMapName);
     
       /**
        * Gives the writer to write the metadata information of this datamap at table level.
    --- End diff --
    
    Please use "Get the datamap writer" to replace "Gives the writer"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---