Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1008-carbondata@git.apache.org>
In-Reply-To: <git-pr-1008-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1008: [CARBONDATA-1145] Fix single-pass issue for m...
Content-Type: text/plain
Message-Id: <20170615080350.339A1DFE15@git1-us-west.apache.org>
Date: Thu, 15 Jun 2017 08:03:50 +0000 (UTC)
archived-at: Thu, 15 Jun 2017 08:03:51 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1008#discussion_r122119776
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java ---
    @@ -51,10 +51,12 @@ public void initializeGeneratorForTable(DictionaryMessage key) {
         CarbonDimension dimension = carbonTable.getPrimitiveDimensionByName(
                 key.getTableUniqueName(), key.getColumnName());
         // initialize TableDictionaryGenerator first
    -    if (tableMap.get(key.getTableUniqueName()) == null) {
    -      tableMap.put(key.getTableUniqueName(), new TableDictionaryGenerator(dimension));
    -    } else {
    -      tableMap.get(key.getTableUniqueName()).updateGenerator(dimension);
    +    synchronized (tableMap) {
    +      if (tableMap.get(key.getTableUniqueName()) == null) {
    --- End diff --
    
    double check should be done before acquiring lock. other wise all reads block each other
    
    if (tableMap.get(key.getTableUniqueName()) == null) {
      syncronized(tableMap){
         if (tableMap.get(key.getTableUniqueName()) == null) {
         }
      }
    }


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---