Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1000-carbondata@git.apache.org>
In-Reply-To: <git-pr-1000-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Content-Type: text/plain
Message-Id: <20170615034636.57D21DFB3A@git1-us-west.apache.org>
Date: Thu, 15 Jun 2017 03:46:35 +0000 (UTC)
archived-at: Thu, 15 Jun 2017 03:46:39 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r122114396
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data, for variable length data type (string,
    +// decimal)
    +public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
    +
    +  // memory allocated by Unsafe
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  // size of the allocated memory, in bytes
    +  private int capacity;
    +
    +  // default size for each row, grows as needed
    +  private static final int DEFAULT_ROW_SIZE = 8;
    +
    +  private static final double FACTOR = 1.25;
    +
    +  UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    capacity = pageSize * DEFAULT_ROW_SIZE;
    +    memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry((long)(capacity * FACTOR));
    +    baseAddress = memoryBlock.getBaseObject();
    +    baseOffset = memoryBlock.getBaseOffset();
    +  }
    +
    +  @Override
    +  public void freeMemory() {
    +    if (memoryBlock != null) {
    +      UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
    +      memoryBlock = null;
    +      baseAddress = null;
    +      baseOffset = 0;
    +    }
    +  }
    +
    +  private void ensureMemory(int requestSize) throws MemoryException {
    +    if (totalLength + requestSize > capacity) {
    +      memoryBlock = UnsafeMemoryManager.reallocateMemoryWithRetry(
    +          memoryBlock, (long)((totalLength + requestSize) * FACTOR));
    --- End diff --
    
    `capacity` should be updated with `(totalLength + requestSize) * FACTOR`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---