Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1008-carbondata@git.apache.org>
In-Reply-To: <git-pr-1008-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1008: [CARBONDATA-1145] Fix single-pass issue for m...
Content-Type: text/plain
Message-Id: <20170614153605.144FADFAF1@git1-us-west.apache.org>
Date: Wed, 14 Jun 2017 15:36:05 +0000 (UTC)
archived-at: Wed, 14 Jun 2017 15:36:08 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1008#discussion_r121983478
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/TableDictionaryGenerator.java ---
    @@ -115,7 +115,10 @@ public Integer size(DictionaryMessage key) {
       }
     
       public void updateGenerator(CarbonDimension dimension) {
    -    columnMap.put(dimension.getColumnId(),
    -            new IncrementalColumnDictionaryGenerator(dimension, 1));
    +    // reuse dictionary generator
    +    if (null == columnMap.get(dimension.getColumnId())) {
    +      columnMap.put(dimension.getColumnId(),
    --- End diff --
    
    ServerDictionaryGenerator.java
    initializeGeneratorForTable() -> if (tableMap.get(key.getTableUniqueName()) == null)  also required lock on tableMap during double checking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---