Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1020-carbondata@git.apache.org>
In-Reply-To: <git-pr-1020-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1020: [CARBONDATA-1155] Load query were failing if ...
Content-Type: text/plain
Message-Id: <20170614120524.8EAF9DFBDA@git1-us-west.apache.org>
Date: Wed, 14 Jun 2017 12:05:23 +0000 (UTC)
archived-at: Wed, 14 Jun 2017 12:05:27 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1020#discussion_r121927124
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -603,7 +603,7 @@ private void copyLocalFileToCarbonStore(String carbonStoreFilePath, String local
         short numberOfByteToStorLength = 2;
         // as length part is removed, so each no dictionary value index
         // needs to be reshuffled by 2 bytes
    -    for (int i = 0; i < dataWriterVo.getNoDictionaryCount(); i++) {
    +    for (int i = 0; i < dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns(); i++) {
    --- End diff --
    
    Please create a local variable for `dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns()`, it is better not put in loop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---