Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: QiangCai <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-995-carbondata@git.apache.org>
In-Reply-To: <git-pr-995-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Content-Type: text/plain
Message-Id: <20170614083445.2B57EE0285@git1-us-west.apache.org>
Date: Wed, 14 Jun 2017 08:34:45 +0000 (UTC)
archived-at: Wed, 14 Jun 2017 08:34:47 -0000

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/995#discussion_r121882386
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java ---
    @@ -27,25 +27,26 @@
     
       private boolean alreadySorted;
     
    -  private short[] dataAfterComp;
    +  private short[] rowIdPage;
     
    -  private short[] indexMap;
    +  private short[] rowIdRlePage;
     
    -  private byte[][] keyBlock;
    +  private byte[][] dataPage;
     
    -  private short[] dataIndexMap;
    +  private short[] dataRlePage;
     
       private int totalSize;
     
    -  public BlockIndexerStorageForShort(byte[][] keyBlock, boolean compressData,
    +  public BlockIndexerStorageForShort(byte[][] dataPage, boolean rleOnData,
           boolean isNoDictionary, boolean isSortRequired) {
    -    ColumnWithShortIndex[] columnWithIndexs = createColumnWithIndexArray(keyBlock, isNoDictionary);
    +    ColumnWithShortIndex[] dataWithRowId = createColumnWithIndexArray(dataPage, isNoDictionary);
         if (isSortRequired) {
    -      Arrays.sort(columnWithIndexs);
    +      Arrays.sort(dataWithRowId);
         }
    -    compressMyOwnWay(extractDataAndReturnIndexes(columnWithIndexs, keyBlock));
    -    if (compressData) {
    -      compressDataMyOwnWay(columnWithIndexs);
    +    short[] rowIds = extractDataAndReturnRowId(dataWithRowId, dataPage);
    --- End diff --
    
    extractDataAndReturnRowId => extractDataAndReturnRowIds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---