Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-987-carbondata@git.apache.org>
In-Reply-To: <git-pr-987-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #987: [CARBONDATA-1017] Add EncodingStrategy and use...
Content-Type: text/plain
Message-Id: <20170613083104.909B7E01C3@git1-us-west.apache.org>
Date: Tue, 13 Jun 2017 08:31:03 +0000 (UTC)
archived-at: Tue, 13 Jun 2017 08:31:07 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/987#discussion_r121613640
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java ---
    @@ -123,4 +121,29 @@ public boolean isMemoryAvailable() {
       public long getUsableMemory() {
         return totalMemory - minimumMemory;
       }
    +
    +  /**
    +   * It tries to allocate memory of `size` bytes, keep retry until it allocates successfully.
    +   */
    +  public static MemoryBlock allocateMemoryBlocking(long size) throws MemoryException {
    --- End diff --
    
    typo `allocateMemoryBlock`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---