Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-971-carbondata@git.apache.org>
In-Reply-To: <git-pr-971-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...
Content-Type: text/plain
Message-Id: <20170602050601.5CB05DFA33@git1-us-west.apache.org>
Date: Fri,  2 Jun 2017 05:06:01 +0000 (UTC)
archived-at: Fri, 02 Jun 2017 05:06:03 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/971#discussion_r119781980
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatistics.java ---
    @@ -114,6 +115,46 @@ private int getDecimalCount(double value) {
         return decimalPlaces;
       }
     
    +  /**
    +   * return min value as byte array
    +   */
    +  public byte[] minBytes() {
    +    return getValueAsBytes(getMin());
    +  }
    +
    +  /**
    +   * return max value as byte array
    +   */
    +  public byte[] maxBytes() {
    +    return getValueAsBytes(getMax());
    +  }
    +
    +  /**
    +   * convert value to byte array
    +   */
    +  private byte[] getValueAsBytes(Object value) {
    +    ByteBuffer b = null;
    +    Object max = getMax();
    --- End diff --
    
    We should use `value` not `getMax()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---