carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunal642 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1053: [CARBONDATA-1188] fixed codec for UpscaleFloa...
Date Sat, 17 Jun 2017 10:44:17 GMT
GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1053

    [CARBONDATA-1188] fixed codec for UpscaleFloatingCodec

    When the table has a column with double datatype then in UpscaleFloatingCodec that value
is being converted to float in the following way **Math.round(factor * value)** 
    
    This converts the value to long and the original value is lost.
    
    Solution:- remove the unncessary convertion to float.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata floating_codec_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit 890f513285f7a084d936917c2ed45b3ccc5193c8
Author: kunal642 <kunal.kapoor@knoldus.in>
Date:   2017-06-17T08:07:08Z

    fixed codec for UpscaleFloatingCodec

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message