carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1121: [CARBONDATA-1215][BUGFIX] Fix unsafe column p...
Date Fri, 30 Jun 2017 12:02:19 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1121#discussion_r125023223
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
    @@ -106,7 +106,7 @@ static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes) throws
MemoryExcep
     
         VarLengthColumnPageBase page;
         if (unsafe) {
    -      page = new UnsafeVarLengthColumnPage(DECIMAL, numRows);
    +      page = new UnsafeVarLengthColumnPage(DECIMAL, numRows, lvEncodedBytes.length);
    --- End diff --
    
    how about to use offset variable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message