carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HoneyQuery <...@git.apache.org>
Subject [GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...
Date Fri, 30 Jun 2017 04:16:00 GMT
Github user HoneyQuery commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1112#discussion_r124961570
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
    @@ -520,7 +626,7 @@ private boolean isValidBlockBasedOnUpdateDetails(
                   int blkIndex;
                   for (
                       bytesRemaining = length;
    -                  (double) bytesRemaining / (double) splitSize > 1.1D;
    +                  (double) bytesRemaining / (double) splitSize > 1.1D;// BHQ: when
there are more than one splits left.
                       bytesRemaining -= splitSize) {
    --- End diff --
    
    OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message